Fix reading pixels on little-endian systems#17
Open
Gorggg wants to merge 1 commit intoEcognize:masterfrom
Open
Fix reading pixels on little-endian systems#17Gorggg wants to merge 1 commit intoEcognize:masterfrom
Gorggg wants to merge 1 commit intoEcognize:masterfrom
Conversation
This fixes an issue where glReadPixels read components out-of-order on little-endian machines, leading to resulting images with inaccurate color values. To fix this, we make the pixel format value conditional on cpu endianness, which we get CMake to identify at compile time.
Member
|
Hello. Sorry I completely forgot about this repo. I'll get back to you as soon as I have time to brief myself back about what was going on here. |
Author
|
Thanks for the reply. My experience of this issue was that images resulting from glReadPixels() had distorted colors. I determined that this was because the resulting format was endianness-dependent, therefore they were reversed in certain scenarios. I fixed the issue by detecting endianness at compile-time and adjusting the format of the operation accordingly. If there is anything more I can help you recall or clarify, please let me know, and thank you for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where glReadPixels read components out-of-order on little-endian machines, leading to resulting images with inaccurate color values. To fix this, we make the pixel format value conditional on cpu endianness, which we get CMake to identify at compile time.
Thank you for reading this. If there is anything I can improve, please let me know.